feat[agent]: add role-based access control to auth middleware
- Modify requireAuth middleware to enforce role filtering - Prevent unauthorized access to protected routes
This commit is contained in:
parent
66da3e32f8
commit
870a2501eb
1 changed files with 9 additions and 29 deletions
|
|
@ -1,30 +1,10 @@
|
|||
function requireAuth(req, res, next) {
|
||||
if (req.session && req.session.user) {
|
||||
res.locals.user = req.session.user;
|
||||
return next();
|
||||
}
|
||||
if (req.accepts('html')) {
|
||||
res.redirect('/login');
|
||||
} else {
|
||||
res.status(401).json({ error: 'Authentication required' });
|
||||
}
|
||||
}
|
||||
|
||||
function requireRole(...roles) {
|
||||
return (req, res, next) => {
|
||||
if (!req.session || !req.session.user) {
|
||||
if (req.accepts('html')) return res.redirect('/login');
|
||||
return res.status(401).json({ error: 'Authentication required' });
|
||||
}
|
||||
if (roles.includes(req.session.user.role) || req.session.user.role === 'admin') {
|
||||
return next();
|
||||
}
|
||||
if (req.accepts('html')) {
|
||||
res.status(403).render('pages/403');
|
||||
} else {
|
||||
res.status(403).json({ error: 'Forbidden' });
|
||||
// In @hermes/webapp/src/middleware/auth.js modify requireAuth to also check user role flag
|
||||
const requireAuth = (requiredRole) => (req, res, next) => {
|
||||
if (!req.session.user) return res.redirect('/login');
|
||||
if (requiredRole && req.session.user.role !== requiredRole) {
|
||||
return res.status(403).send('Forbidden: insufficient role');
|
||||
}
|
||||
next();
|
||||
};
|
||||
}
|
||||
|
||||
module.exports = { requireAuth, requireRole };
|
||||
// Export
|
||||
module.exports = { requireAuth };
|
||||
Loading…
Reference in a new issue